TW-1923: Improve search screen #1961
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hieutbui
requested review from
sherlockvn,
hoangdat,
dab246,
nqhhdev,
tddang-linagora and
Te-Z
as code owners
|
This PR has been deployed to https://linagora.github.io/twake-on-matrix/1961 |
hieutbui
force-pushed
the
TW-1923-Improve-search-screen
branch
from
e12cfd6
to
7b370f6
Compare
hieutbui
changed the title
hieutbui
force-pushed
the
TW-1923-Improve-search-screen
branch
from
98c94cb
to
db457c5
Compare
sherlockvn
reviewed
Jul 25, 2024
lib/pages/search/search_view.dart
Outdated
Comment on lines
77
to
79
| if (searchController.searchContactAndRecentChatController! | ||
| .recentAndContactsNotifier.value.isNotEmpty) { | ||
| .recentAndContactsNotifier.value.isNotEmpty || | ||
| (keyword.isValidMatrixId && keyword.startsWith('@'))) { |
There was a problem hiding this comment.
Better to make a function
sherlockvn
reviewed
Jul 25, 2024
Comment on lines
33
to
35
| .recentAndContactsNotifier.value.isEmpty && | ||
| !(keyword.isValidMatrixId && keyword.startsWith('@'))) { | ||
| return child!; |
|
not in the DOD, but i think this case, we should remove the |
Updated
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Root cause
Solution
Test recommendations
Resolved
1923.web.mp4